On 8/3/20 5:18 PM, Jens Axboe wrote: > On 8/3/20 4:30 PM, Jens Axboe wrote: >>> Adding random kiocb helper functions to a core header file, when they >>> are only used in one place, and when they only make sense in that one >>> place? >>> >>> Not ok. >> >> I'll move that into io_uring instead. > > I see that you handled most of the complaints already, so thanks for > that. I've run some basic testing with master and it works for me, > running some more testing on production too. > > I took a look at the rewrite you queued up, and made a matching change > on the io_uring side: > > https://git.kernel.dk/cgit/linux-block/commit/?h=io_uring-5.9&id=419ebeb6f2d0d56f6b2844c0f77034d1048e37e9 Updated to honor exclusive return value as well: https://git.kernel.dk/cgit/linux-block/commit/?h=io_uring-5.9&id=f6fd3784c9f7d3309507fdb6dcc818f54467bf3e -- Jens Axboe
