On 8/3/20 4:30 PM, Jens Axboe wrote: >> Adding random kiocb helper functions to a core header file, when they >> are only used in one place, and when they only make sense in that one >> place? >> >> Not ok. > > I'll move that into io_uring instead. I see that you handled most of the complaints already, so thanks for that. I've run some basic testing with master and it works for me, running some more testing on production too. I took a look at the rewrite you queued up, and made a matching change on the io_uring side: https://git.kernel.dk/cgit/linux-block/commit/?h=io_uring-5.9&id=419ebeb6f2d0d56f6b2844c0f77034d1048e37e9 and also queued a documentation patch for the retry logic and the callback handler: https://git.kernel.dk/cgit/linux-block/commit/?h=io_uring-5.9&id=9541a9d4791c2d31ba74b92666edd3f1efd936a8 For the latter, let me know if you're happy with the explanation, or if you want other parts documented more thoroughly too. I'll make a pass through the file in any case once I've flushed out the other branches for this merge window in. -- Jens Axboe
