On 4/13/20 8:18 AM, Jens Axboe wrote: > On 4/13/20 1:19 AM, Xiaoguang Wang wrote: >> Indeed I'm not sure this patch is necessary, robust applications >> should not call io_uring_submit when there are not sqes to submmit. >> But still try to add this check, I have seen some applications which >> call io_uring_submit(), but there are not sqes to submit. > > Hmm, not sure it's worth complicating the submit path for that case. > A high performant application should not call io_uring_submit() if > it didn't queue anything new. Is this a common case you've seen? Looking at it again, it actually seems quite reasonable. I've queued it up, thanks! -- Jens Axboe
