Re: [LIBURING PATCH] sq_ring_needs_enter: check whether there are sqes when SQPOLL is not enabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/13/20 1:19 AM, Xiaoguang Wang wrote:
> Indeed I'm not sure this patch is necessary, robust applications
> should not call io_uring_submit when there are not sqes to submmit.
> But still try to add this check, I have seen some applications which
> call io_uring_submit(), but there are not sqes to submit.

Hmm, not sure it's worth complicating the submit path for that case.
A high performant application should not call io_uring_submit() if
it didn't queue anything new. Is this a common case you've seen?

-- 
Jens Axboe




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux