Re: [PATCH 04/14] drm: Move master functions into drm_auth.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 15, 2016 at 12:31:20PM +0100, Chris Wilson wrote:
> On Tue, Jun 14, 2016 at 08:50:59PM +0200, Daniel Vetter wrote:
> > For modern drivers pretty much the only thing drm_master does is
> > handling authentication for the primary/legacy drm_minor node. Instead
> > of having it all over drm files, move it all together into drm_auth.c.
> > 
> > This patch just does code-motion, follow up patches will also extract
> > the master logic from file open&release paths.
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>
> 
> What else is to come? Wondering why drm_auth.c rather than drm_master.c?

Yeah, I guess we could rename it to drm_master, probably makes more sense.
Otoh the only reason we have a drm_master is to support the DRM_AUTH ioctl
restriction, so drm_auth seems to fit, too.

I went with the lazy approach of sticking to what's there already ;-)
-Daniel

> 
> Looks mechanical, so
> Reviewed-by: Chris Wilson Mchris@xxxxxxxxxxxxxxxxxx>
> -Chris
> 
> -- 
> Chris Wilson, Intel Open Source Technology Centre

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux