On Mon, May 30, 2016 at 5:45 PM, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote: >> state->connectors[i].connector is really long, and makes a lot of code >> look ugly. "obj" might be a bit better than "ptr" at least. Something >> else? > > How often are you expecting to have to type this anyway? Using any > kind of generic name here will make life harder for cscope users. > Atomic is really bad in this regard, escecially with all the identically > named function pointers. It's seriosuly hard to navigate that maze > these days. Someone should do a bit of renaming of stuff to make > things more unique. We have the same aliasing with legacy hooks shared between encoder/bridge&crtc. I just always search for the containing structure since indeed there's no other way to find stuff. Plus big screens ;-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
