Re: [PATCH] drm/i915/sysfs: Adding mocs_state

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 04, 2016 at 02:32:53PM +0100, Peter Antoine wrote:
> Will wait for more comments, then will respin with a different
> commit message. Is the rest of the patch ok?

No, you've put debug information into sysfs. (Also sysfs is one value per
file.) sysfs does not match your goal of validation. And you exported an
internal function (get_mocs...) without giving it a proper name.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux