Re: [PATCH i-g-t 2/2] tests/kms_flip: Half the duration time for basic-*vs-modeset/flip tests.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 20, 2016 at 08:49:57PM +0300, Marius Vlad wrote:
> basic-flip-vs-dpms and basic-flip-vs-modeset together take roughly 2m
> to run. Adjust the duration time to a maximum of 500ms.

Can we have a notch more please? Ime it takes generally a few modesets for
this thing to fall over (2-3 modesets), are you sure the test still does
something useful in half a second? Mostly a modeset takes a lot longer
than that.

Also you just half the duration, but claim it goes from 2minutes to 500 ms
...

I'm confused.
-Daniel

> 
> Signed-off-by: Marius Vlad <marius.c.vlad@xxxxxxxxx>
> ---
>  tests/kms_flip.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index 3d44544..fd8206f 100644
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -1458,7 +1458,7 @@ static int run_test(int duration, int flags)
>  	}
>  
>  	igt_require(modes);
> -	duration = duration * 1000 / modes;
> +	duration = duration * 500 / modes;
>  	duration = max(500, duration);
>  
>  	/* Find any connected displays */
> -- 
> 2.5.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux