Hi, On 5 March 2016 at 12:34, Daniel Vetter <daniel@xxxxxxxx> wrote: > On Wed, Mar 02, 2016 at 03:00:07PM +0100, Tomeu Vizoso wrote: >> have restarted work on getting tests in IGT to run on drivers other than >> i915. >> >> These changes make the modified tests pass in a Radxa Rock2 board by >> using dumb buffers as much as possible and having subtests skip if they >> require tiled BOs. The plan is for igt_create_bo_with_dimensions to be >> able to hide differences in the buffer creation API as much as possible. > > lgtm to me overall. Some small comments on the library, but with those > addressed imo ready to go. Would be great if someone else (Daniel Stone?) > could check the final patches in detail before pushing, but upfront ack > from my side. I went through and reviewed the changes here, and have been happy with them after some very minor bikeshedding. The updated versions also addressed all the other comments which came up on the list. So I've pushed them with my review, passing on Intel, Rockchip and VC4. Latter updates to get the flip/vblank/etc tests running have also exposed some bugs in Rockchip and VC4 both. :) Cheers, Daniel _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
