On Wed, Mar 02, 2016 at 03:00:07PM +0100, Tomeu Vizoso wrote: > Hi, > > have restarted work on getting tests in IGT to run on drivers other than > i915. > > These changes make the modified tests pass in a Radxa Rock2 board by > using dumb buffers as much as possible and having subtests skip if they > require tiled BOs. The plan is for igt_create_bo_with_dimensions to be > able to hide differences in the buffer creation API as much as possible. lgtm to me overall. Some small comments on the library, but with those addressed imo ready to go. Would be great if someone else (Daniel Stone?) could check the final patches in detail before pushing, but upfront ack from my side. Cheers, Daniel > > Thanks, > > Tomeu > > > Tomeu Vizoso (14): > lib: add igt_require_intel > lib: Have gem_set_tiling require intel > lib: Expose is_i915_device > lib: Have intel_get_drm_devid call igt_require_intel > lib: Call intel_get_drm_devid only from intel code > lib: Add wrapper for DRM_IOCTL_MODE_CREATE_DUMB > lib: Map dumb buffers > lib: Add igt_create_bo_with_dimensions > tests: Open any driver > kms_addfb_basic: call igt_create_bo_with_dimensions > kms_addfb_basic: move tiling functionality into each subtest > kms_addfb_basic: Split tiling_tests off > kms_addfb_basic: Move calls to gem_set_tiling to the subtests > kms_addfb_basic: Get intel gen from within subtest > > lib/drmtest.c | 7 ++- > lib/drmtest.h | 4 ++ > lib/igt_fb.c | 116 +++++++++++++++++++++++++++++++++------------- > lib/igt_fb.h | 6 +++ > lib/igt_kms.c | 2 +- > lib/intel_chipset.c | 2 + > lib/ioctl_wrappers.c | 38 +++++++++++++++ > lib/ioctl_wrappers.h | 1 + > tests/drm_read.c | 18 +------ > tests/gem_exec_blt.c | 18 +------ > tests/kms_addfb_basic.c | 121 +++++++++++++++++++++++++++++++++++------------- > tests/kms_atomic.c | 2 +- > tests/kms_setmode.c | 2 +- > tests/kms_vblank.c | 2 +- > 14 files changed, 235 insertions(+), 104 deletions(-) > > -- > 2.5.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
