Re: [PATCH v3 1/3] drm/i915: Use i915_vm_to_ppgtt instead of manual container_of

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 01, 2016 at 10:46:41AM +0300, Joonas Lahtinen wrote:
> Looks much better without container_of everywhere.
> 
> v2:
> - In i915_gem_restore_gtt_mappings too (Chris)
> 
> v3:
> - Do not cause WARN by calling on non PPGTT object (Chris)
> 
> Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>

Minor disgruntle at seeing an extra line I have to change (vm->is_ggtt!),
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux