On ke, 2016-03-23 at 13:25 +0000, Chris Wilson wrote: > On Wed, Mar 23, 2016 at 03:00:23PM +0200, Joonas Lahtinen wrote: > > > > Refer to the GGTT VM consistently as "ggtt_vm" instead of just "ggtt", > > "vm" or indirectly through other variables like "dev_priv->ggtt.base" > > to avoid confusion with the i915_ggtt object itself and PPGTT VMs. > On the one hand, yes it seems more fitting to call it ggtt_vm. On the > other, we've been pretty consistent in calling the address space ggtt! > And I like the look of ggtt far more than ggtt_vm. Killing off more > mixed dev_priv->ggtt.base and ggtt pointer usage is definitely good > though. But I'm ambivalent about the whole. Right, ppgtt->base is also being used quite some so I guess you're right. I'll reroll the patches to get rid of ggtt_vm's everywhere and use ggtt->base. (I myself hate the convention, but lets stick to one convention). Regards, Joonas > -Chris > -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
