On Thu, 2016-03-17 at 21:48 +0000, Chris Wilson wrote: > On Thu, Mar 17, 2016 at 11:10:42PM +0200, Imre Deak wrote: > > Well, I can follow-up on an export patch for that, but getting that > > merged may take a while, so could we go with the current version > > until > > that? > > What's the current version? ;) v3. Actually you were right, there is a reason why no dev_vprintk exists. It's because dev_printk provides that with %pV. So learned something new today and it wasn't a nuisance.. I'll use that then and a function instead of the macro. > For my tastes, I really want the "please file a bug" to be separate, > and I think KERN_NOTICE. Ok, I used KERN_INFO but will change that to KERN_NOTICE. > I would also like this to be the preferred > DRM_ERROR reporting mechanism i.e. anytime we emit an ERROR we should > be > encouraging the user to file a bug, and do so in a user friendly > fashion. Ok, but only in i915 I assume. Should we also convert then all DRM_ERROR to dev_err - with an *ERROR* prefix - or still use DRM_ERROR? --Imre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
