On Thu, Mar 17, 2016 at 06:08:05PM +0200, Imre Deak wrote: > On Thu, 2016-03-17 at 15:55 +0000, Chris Wilson wrote: > > 80cols rules still apply to messages :) > > > > "Device initialization failed (%d). " > > "Please file a bug at https://bugs.freedesktop.org/enter_bug.cgi " > > "against DRI/DRM/Intel providing the dmesg log by booting " > > "with drm.debug=0xf\n", > > I thought for strings emitted to dmesg it's discouraged, since you > can't easily grep then. But I can make the link more precise. Hmm, we haven't abided by that. I don't mind really :) > > I would personally make i915_load_error() a proper function and add > > the "Please..." output there at a lower logging level than ERROR. > > Using a function is not straightforward since there is no vprintf like > interface for DRM_ERROR. But I can move that part of the message to > macro. In that case, I'm happy enough with ditching the DRM_ERROR here and go with dev_err(). Another nail in the DRM_ERROR coffin. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
