Re: [PATCH] sna: move up the assert check before DBG print message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> On Tue, Mar 01, 2016 at 09:49:21AM +0800, Lim Siew Hoon wrote:
> > The assert check for c->bo should be done before DBG, else it will hit
> > memory access violation when c->bo is null.
> >
> > Signed-off-by: Lim Siew Hoon <siew.hoon.lim@xxxxxxxxx>
> > Reviewed-by: Matt Roper <matthew.d.roper@xxxxxxxxx>
> 
> Pardon? With a r-b?

What is a r-b? 
I'm helping to fix the KW issue hit in our repo side. 
I suggest the assert checking should be move up before DBG(...) print statement to avoid memory access violation happen if c->bo is NULL for print message. 
Of cause the chance will be very low to get c->bo is NULL.  

...siewhoon

> -Chris
> 
> --
> Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux