Re: [PATCH v2] drm/i915: Decouple execbuf uAPI from internal implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Fri, Jan 15, 2016 at 03:12:50PM +0000, Tvrtko Ursulin wrote:
> > From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> > +	if (user_ring_id == I915_EXEC_BSD && HAS_BSD2(dev_priv)) {
> > +		unsigned int bsd_idx = args->flags & I915_EXEC_BSD_MASK;
> > +
> > +		if (bsd_idx == I915_EXEC_BSD_DEFAULT) {
> > +			bsd_idx = gen8_dispatch_bsd_ring(dev_priv, file);
> > +		} else if (bsd_idx >= I915_EXEC_BSD_RING1 &&
> > +			   bsd_idx <= I915_EXEC_BSD_RING2) {
> > +			bsd_idx--;

There is one regression here, I915_EXEC_BSD_RING1/2 is left-shifted 13 bits, 
so we should add something like
	bsd_idx >>= 13;
Otherwise the kernel panics. 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux