Re: [PATCH 0/7] Misc WM fixes and Arbitrated Display Bandwidth WA for SKL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 15, 2016 at 10:32 AM, Kumar, Shobhit <shobhit.kumar@xxxxxxxxxxxxxxx> wrote:
On 01/15/2016 07:18 AM, Matt Roper wrote:
On Thu, Jan 14, 2016 at 05:32:41PM +0530, Shobhit Kumar wrote:
Hi,
This series add a set of updates to the WM calculation and also enables
arbitrated display bandwidth based WA. Some of these patches do overlap
with Matts work but we wanted to send them out as we have them in our
internal testing for early review. Most likley some of them can be
superceded by patches from Matt, or can be re-used if deemed necessary.

I've left some feedback on your patches, but it was all pretty minor;
they look pretty good overall.  So I think we should polish up this set
and merge it; I've got more SKL WM work coming (more atomic-y watermark
calculation and programming) but I'll hold off on that until your series
lands so that I don't cause too much thrash.

Thanks Matt for the quick review. I will get the comments addressed and final patches uploaded quickly.

We have the updated patches ready. Just completing some testing. Should be posting sometime this week.

Regards
Shobhit
 

Regards
Shobhit



Thanks.


Matt


Especially "drm/i915/skl+: Use fb size for relative data rate calculation"
this already addresses some of Ville's comment on similar patch from Matt.

Regards
Shobhit

Kumar, Mahesh (6):
   drm/i915/skl+: Use proper bytes_per_pixel during WM calculation
   drm/i915/skl+: Use fb size for relative data rate calculation
   drm/i915/skl+: calculate ddb minimum allocation
   drm/i915/skl+: calculate plane pixel rate.
   drm/i915/skl+: Use scaling amount for plane data rate calculation
   drm/i915/skl: WA for watermark calculation based on Arbitrated Display
     BW

Shobhit Kumar (1):
   drm/i915: Add support to parse DMI table and get platform memory info

  drivers/gpu/drm/i915/i915_dma.c  |  19 +++
  drivers/gpu/drm/i915/i915_drv.h  |  15 ++
  drivers/gpu/drm/i915/intel_drv.h |   2 +
  drivers/gpu/drm/i915/intel_pm.c  | 294 +++++++++++++++++++++++++++++++++++++--
  4 files changed, 316 insertions(+), 14 deletions(-)

--
2.4.3


_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux