On Thu, 21 Jan 2016, "Adebisi, YetundeX" <yetundex.adebisi@xxxxxxxxx> wrote: > Hi, > > I got this message in reply to this patch (https://patchwork.freedesktop.org/patch/60736/). > > It looks like most of the warnings are related to 'PWM1 enabled' > warnings that happen when the hardware is going into some power > management state and BLM_PWM_ENABLE and/or BLM_PCH_PWM_ENABLE are > enabled on the bdw-ultra platform. This sounds plausible if the panel actually has DPCD controlled backlight; I was unable to confirm from the CI logs. The BIOS probably enables the PWMs at boot, and then we don't disable. What confuses me is that the backlight works on the machine *without* your patches. IIUC your patch should only enable DPCD backlight control if the DPCD says PWM control is not available. > What is the best way to fix this? If my patch is used then the > function that disables BLM_PWM_ENABLE and/or BLM_PCH_PWM_ENABLE > (lpt_disable_backlight) will not be called. > > Should I disable this DPCD backlight control featured for BDW or > specifically disable these bits in my intel_dp_aux_enable_backlight > function? Whether it makes sense or not, I predict the BIOSes of all machines to blindly enable the PWMs. Including when the panel really doesn't support PWM control. So we need to sanitize these registers. See the comment in lpt_disable_backlight, this is already the case for CPU PWM when only PCH PWM is used. I think the right approach would be to sanitize the state at setup time instead of disable time. The BDW in question is some development platform, I don't think you could buy it. So it's a bit special, but we have it in CI because it has some other features we like to test. Not sure how much conclusions one can really draw from it. BR, Jani. > > Thank you. > > Yetunde > > > Dmesg warn output > > [ 357.655508] ------------[ cut here ]------------ > [ 357.655536] WARNING: CPU: 1 PID: 43 at drivers/gpu/drm/i915/intel_display.c:9518 hsw_enable_pc8+0x609/0x730 [i915]() > [ 357.655537] CPU PWM1 enabled > [ 357.655539] Modules linked in: i915 ax88179_178a i2c_hid x86_pkg_temp_thermal intel_powerclamp coretemp crct10dif_pclmul crc32_pclmul cdc_ncm usbnet mii mei_me mei lpc_ich i2c_designware_platform i2c_designware_core e1000e sdhci_pci ptp pps_core sdhci_acpi sdhci mmc_core [last unloaded: i915] > [ 357.655559] CPU: 1 PID: 43 Comm: kworker/1:1 Tainted: G U W 4.4.0-gfxbench+ #1 > [ 357.655560] Hardware name: Intel Corporation Broadwell Client platform/Wilson Beach SDS, BIOS BDW-E2R1.86C.0095.R09.1410300006 10/30/2014 > [ 357.655565] Workqueue: pm pm_runtime_work > [ 357.655567] ffffffffa03e7ce8 ffff8800ab8e3b68 ffffffff813df90c ffff8800ab8e3bb0 > [ 357.655570] ffff8800ab8e3ba0 ffffffff810746e1 ffff8802308c0000 ffff880240341898 > [ 357.655573] ffff8802403418a8 ffff880240341148 ffff880243bd3470 ffff8800ab8e3c00 > [ 357.655576] Call Trace: > [ 357.655580] [<ffffffff813df90c>] dump_stack+0x4e/0x82 > [ 357.655583] [<ffffffff810746e1>] warn_slowpath_common+0x81/0xc0 > [ 357.655585] [<ffffffff81074767>] warn_slowpath_fmt+0x47/0x50 > [ 357.655603] [<ffffffffa0378329>] hsw_enable_pc8+0x609/0x730 [i915] > [ 357.655610] [<ffffffffa02f4eba>] intel_suspend_complete+0xca/0x6c0 [i915] > [ 357.655617] [<ffffffffa02f578b>] intel_runtime_suspend+0xdb/0x2d0 [i915] > [ 357.655620] [<ffffffff81425496>] pci_pm_runtime_suspend+0x56/0x190 > [ 357.655623] [<ffffffff81425440>] ? pci_pm_runtime_resume+0xa0/0xa0 > [ 357.655626] [<ffffffff8152417d>] __rpm_callback+0x2d/0x70 > [ 357.655628] [<ffffffff81425440>] ? pci_pm_runtime_resume+0xa0/0xa0 > [ 357.655631] [<ffffffff815241df>] rpm_callback+0x1f/0x80 > [ 357.655633] [<ffffffff81425440>] ? pci_pm_runtime_resume+0xa0/0xa0 > [ 357.655635] [<ffffffff815246c8>] rpm_suspend+0x148/0x780 > [ 357.655638] [<ffffffff81526276>] pm_runtime_work+0x76/0xc0 > [ 357.655641] [<ffffffff8108f415>] process_one_work+0x1e5/0x620 > [ 357.655642] [<ffffffff8108f379>] ? process_one_work+0x149/0x620 > [ 357.655645] [<ffffffff8108f899>] worker_thread+0x49/0x450 > [ 357.655646] [<ffffffff8108f850>] ? process_one_work+0x620/0x620 > [ 357.655648] [<ffffffff8108f850>] ? process_one_work+0x620/0x620 > [ 357.655651] [<ffffffff81095eca>] kthread+0xea/0x100 > [ 357.655653] [<ffffffff81799e17>] ? _raw_spin_unlock_irq+0x27/0x50 > [ 357.655656] [<ffffffff81095de0>] ? kthread_create_on_node+0x1f0/0x1f0 > [ 357.655658] [<ffffffff8179aabf>] ret_from_fork+0x3f/0x70 > [ 357.655661] [<ffffffff81095de0>] ? kthread_create_on_node+0x1f0/0x1f0 > [ 357.655662] ---[ end trace d4f8f254173751a9 ]--- > [ 357.655665] ------------[ cut here ]------------ > [ 357.655682] WARNING: CPU: 1 PID: 43 at drivers/gpu/drm/i915/intel_display.c:9523 hsw_enable_pc8+0x701/0x730 [i915]() > [ 357.655683] PCH PWM1 enabled > [ 357.655684] Modules linked in: i915 ax88179_178a i2c_hid x86_pkg_temp_thermal intel_powerclamp coretemp crct10dif_pclmul crc32_pclmul cdc_ncm usbnet mii mei_me mei lpc_ich i2c_designware_platform i2c_designware_core e1000e sdhci_pci ptp pps_core sdhci_acpi sdhci mmc_core [last unloaded: i915] > [ 357.655699] CPU: 1 PID: 43 Comm: kworker/1:1 Tainted: G U W 4.4.0-gfxbench+ #1 > [ 357.655701] Hardware name: Intel Corporation Broadwell Client platform/Wilson Beach SDS, BIOS BDW-E2R1.86C.0095.R09.1410300006 10/30/2014 > [ 357.655704] Workqueue: pm pm_runtime_work > [ 357.655705] ffffffffa03e7ce8 ffff8800ab8e3b68 ffffffff813df90c ffff8800ab8e3bb0 > [ 357.655708] ffff8800ab8e3ba0 ffffffff810746e1 ffff8802308c0000 ffff880240341898 > [ 357.655711] ffff8802403418a8 ffff880240341148 ffff880243bd3470 ffff8800ab8e3c00 > [ 357.655714] Call Trace: > [ 357.655716] [<ffffffff813df90c>] dump_stack+0x4e/0x82 > [ 357.655718] [<ffffffff810746e1>] warn_slowpath_common+0x81/0xc0 > [ 357.655720] [<ffffffff81074767>] warn_slowpath_fmt+0x47/0x50 > [ 357.655736] [<ffffffffa0378421>] hsw_enable_pc8+0x701/0x730 [i915] > [ 357.655743] [<ffffffffa02f4eba>] intel_suspend_complete+0xca/0x6c0 [i915] > [ 357.655750] [<ffffffffa02f578b>] intel_runtime_suspend+0xdb/0x2d0 [i915] > [ 357.655753] [<ffffffff81425496>] pci_pm_runtime_suspend+0x56/0x190 > [ 357.655755] [<ffffffff81425440>] ? pci_pm_runtime_resume+0xa0/0xa0 > [ 357.655758] [<ffffffff8152417d>] __rpm_callback+0x2d/0x70 > [ 357.655760] [<ffffffff81425440>] ? pci_pm_runtime_resume+0xa0/0xa0 > [ 357.655763] [<ffffffff815241df>] rpm_callback+0x1f/0x80 > [ 357.655765] [<ffffffff81425440>] ? pci_pm_runtime_resume+0xa0/0xa0 > [ 357.655767] [<ffffffff815246c8>] rpm_suspend+0x148/0x780 > [ 357.655770] [<ffffffff81526276>] pm_runtime_work+0x76/0xc0 > [ 357.655772] [<ffffffff8108f415>] process_one_work+0x1e5/0x620 > [ 357.655773] [<ffffffff8108f379>] ? process_one_work+0x149/0x620 > [ 357.655775] [<ffffffff8108f899>] worker_thread+0x49/0x450 > [ 357.655777] [<ffffffff8108f850>] ? process_one_work+0x620/0x620 > [ 357.655779] [<ffffffff8108f850>] ? process_one_work+0x620/0x620 > [ 357.655781] [<ffffffff81095eca>] kthread+0xea/0x100 > [ 357.655783] [<ffffffff81799e17>] ? _raw_spin_unlock_irq+0x27/0x50 > [ 357.655786] [<ffffffff81095de0>] ? kthread_create_on_node+0x1f0/0x1f0 > [ 357.655788] [<ffffffff8179aabf>] ret_from_fork+0x3f/0x70 > [ 357.655790] [<ffffffff81095de0>] ? kthread_create_on_node+0x1f0/0x1f0 > [ 357.655791] ---[ end trace d4f8f254173751aa ]--- > > >> -----Original Message----- >> From: Patchwork [mailto:patchwork@xxxxxxxxxxxxxxxxxxxxxxxx] >> Sent: Tuesday, January 12, 2016 5:50 PM >> To: Adebisi, YetundeX >> Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx >> Subject: ✗ warning: Fi.CI.BAT >> >> == Summary == >> >> Built on 9a47f23e3744929b9b222cb750994723fff0e5ee drm-intel-nightly: >> 2016y-01m-12d-16h-55m-40s UTC integration manifest >> >> Test gem_storedw_loop: >> Subgroup basic-render: >> pass -> DMESG-WARN (skl-i5k-2) UNSTABLE >> pass -> DMESG-WARN (bdw-nuci7) >> pass -> DMESG-WARN (bdw-ultra) >> Test kms_flip: >> Subgroup basic-flip-vs-modeset: >> dmesg-warn -> PASS (skl-i5k-2) >> pass -> DMESG-WARN (bdw-ultra) >> Subgroup basic-plain-flip: >> pass -> DMESG-WARN (bdw-ultra) >> Test kms_pipe_crc_basic: >> Subgroup nonblocking-crc-pipe-a-frame-sequence: >> pass -> DMESG-WARN (bdw-ultra) >> Subgroup nonblocking-crc-pipe-b-frame-sequence: >> pass -> DMESG-WARN (bdw-ultra) >> Subgroup read-crc-pipe-a: >> pass -> DMESG-WARN (bdw-ultra) >> Subgroup read-crc-pipe-a-frame-sequence: >> pass -> DMESG-WARN (bdw-ultra) >> Subgroup read-crc-pipe-b: >> pass -> DMESG-WARN (bdw-ultra) >> Subgroup read-crc-pipe-b-frame-sequence: >> pass -> DMESG-WARN (bdw-ultra) >> Subgroup read-crc-pipe-c: >> pass -> DMESG-WARN (bdw-ultra) >> Test pm_rpm: >> Subgroup basic-pci-d3-state: >> pass -> DMESG-WARN (bdw-ultra) >> Subgroup basic-rte: >> pass -> DMESG-WARN (bdw-ultra) >> >> bdw-nuci7 total:138 pass:128 dwarn:1 dfail:0 fail:0 skip:9 >> bdw-ultra total:138 pass:120 dwarn:12 dfail:0 fail:0 skip:6 >> bsw-nuc-2 total:141 pass:115 dwarn:2 dfail:0 fail:0 skip:24 >> byt-nuc total:141 pass:123 dwarn:3 dfail:0 fail:0 skip:15 >> hsw-brixbox total:141 pass:134 dwarn:0 dfail:0 fail:0 skip:7 >> hsw-gt2 total:141 pass:137 dwarn:0 dfail:0 fail:0 skip:4 >> hsw-xps12 total:138 pass:133 dwarn:1 dfail:0 fail:0 skip:4 >> ilk-hp8440p total:141 pass:101 dwarn:3 dfail:0 fail:0 skip:37 >> ivb-t430s total:135 pass:122 dwarn:3 dfail:4 fail:0 skip:6 >> skl-i5k-2 total:141 pass:131 dwarn:2 dfail:0 fail:0 skip:8 >> skl-i7k-2 total:141 pass:131 dwarn:2 dfail:0 fail:0 skip:8 >> snb-dellxps total:141 pass:122 dwarn:5 dfail:0 fail:0 skip:14 >> snb-x220t total:141 pass:122 dwarn:5 dfail:0 fail:1 skip:13 >> >> Results at /archive/results/CI_IGT_test/Patchwork_1154/ > -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
