Re: [PATCH v4 06/38] drm/i915: Re-instate request->uniq because it is extremely useful

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/01/2016 22:04, Chris Wilson wrote:
On Mon, Jan 11, 2016 at 06:42:35PM +0000, John.C.Harrison@xxxxxxxxx wrote:
From: John Harrison <John.C.Harrison@xxxxxxxxx>

The seqno value cannot always be used when debugging issues via trace
points. This is because it can be reset back to start, especially
during TDR type tests. Also, when the scheduler arrives the seqno is
only valid while a given request is executing on the hardware. While
the request is simply queued waiting for submission, it's seqno value
will be zero (meaning invalid).
Even with per-context seqno that can be assigned before execution as we
know that requests within a context cannot be reordered?
-Chris

Firstly, we do not have per-context seqno values at the moment. However, even if we did that would make a per request unique value even more useful as the only way to identify a given request then would be through a context pointer and seqno pair which would make scanning through debug traces even worse.

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux