2015-12-08 11:42 GMT-02:00 Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>: > On Tue, Dec 08, 2015 at 10:50:39AM +0200, David Weinehall wrote: >> Since the defaults for some external power management related settings >> prevents us from testing our power management functionality properly, >> we have to work around it. Currently this is done from the individual >> test cases, but this is sub-optimal. This patch moves the PM-related >> workarounds into a separate library, and adds some code to restore the >> previous settings for the SATA link power management while at it. > > Why is it called "workarounds"? That gives me the impression we're > working around something that's supposed to work but doesn't. That's not > the case here. Well, in theory they could be considered workarounds since IMHO the machine is supposed to be saving as much power as it can on an idle state, but it isn't. But this more of a philosophical discussion and we can debate forever. Anyway, if we rename the file to something like lib/igt_pm.c we'll be able to move the residency-checking code and possibly more common things there, so I'm not against the rename either. > >> >> This patch should be seen as a RFC; there might be other workarounds >> for external issues that should be moved into the library, and if those >> workarounds aren't related to power management it might be better to >> choose a different name for the library. >> >> David Weinehall (1): >> lib/pm_workarounds: Lib for PM workarounds >> >> lib/Makefile.sources | 2 + >> lib/igt.h | 1 + >> lib/igt_aux.c | 15 +--- >> lib/pm_workarounds.c | 233 +++++++++++++++++++++++++++++++++++++++++++++++++++ >> lib/pm_workarounds.h | 31 +++++++ >> tests/pm_lpsp.c | 25 +----- >> tests/pm_rpm.c | 29 ++----- >> 7 files changed, 279 insertions(+), 57 deletions(-) >> create mode 100644 lib/pm_workarounds.c >> create mode 100644 lib/pm_workarounds.h >> >> -- >> 2.6.2 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- > Ville Syrjälä > Intel OTC > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Paulo Zanoni _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
