Re: [PATCH i-g-t] RFC: split PM workarounds into separate lib

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 08, 2015 at 10:50:39AM +0200, David Weinehall wrote:
> Since the defaults for some external power management related settings
> prevents us from testing our power management functionality properly,
> we have to work around it. Currently this is done from the individual
> test cases, but this is sub-optimal.  This patch moves the PM-related
> workarounds into a separate library, and adds some code to restore the
> previous settings for the SATA link power management while at it.

Why is it called "workarounds"? That gives me the impression we're
working around something that's supposed to work but doesn't. That's not
the case here.

> 
> This patch should be seen as a RFC; there might be other workarounds
> for external issues that should be moved into the library, and if those
> workarounds aren't related to power management it might be better to
> choose a different name for the library.
> 
> David Weinehall (1):
>   lib/pm_workarounds: Lib for PM workarounds
> 
>  lib/Makefile.sources |   2 +
>  lib/igt.h            |   1 +
>  lib/igt_aux.c        |  15 +---
>  lib/pm_workarounds.c | 233 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  lib/pm_workarounds.h |  31 +++++++
>  tests/pm_lpsp.c      |  25 +-----
>  tests/pm_rpm.c       |  29 ++-----
>  7 files changed, 279 insertions(+), 57 deletions(-)
>  create mode 100644 lib/pm_workarounds.c
>  create mode 100644 lib/pm_workarounds.h
> 
> -- 
> 2.6.2
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux