On Tue, Nov 24, 2015 at 02:57:04PM +0100, Daniel Vetter wrote: > On Fri, Nov 20, 2015 at 12:43:42PM +0000, Chris Wilson wrote: > > In a few frequent cases, having a direct pointer to the drm_i915_private > > from the request is very useful. > > > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > req->i915 is a bit inconsistent imo, i915_dev would be better. Anyway, not > something you started, just makes the code a bit harder to speed-read ;-) How does it strike you as inconsistent? rq->i915 was nicer :-p The idea I have been trying to sell is i915->drm->dev for the struct drm_i915_private / struct drm_device / struct device triplet. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
