On Mon, Nov 23, 2015 at 12:15:18PM +0200, Jani Nikula wrote: > > Accidental patch? Yup, dunno how that one ended up in there ... -Daniel > > On Mon, 23 Nov 2015, Daniel Vetter <daniel.vetter@xxxxxxxx> wrote: > > --- > > drivers/gpu/drm/drm_bufs.c | 14 ++++++++++---- > > include/drm/drm_legacy.h | 2 +- > > 2 files changed, 11 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_bufs.c b/drivers/gpu/drm/drm_bufs.c > > index de18b8b78a26..5a51633da033 100644 > > --- a/drivers/gpu/drm/drm_bufs.c > > +++ b/drivers/gpu/drm/drm_bufs.c > > @@ -542,15 +542,17 @@ int drm_legacy_rmmap_locked(struct drm_device *dev, struct drm_local_map *map) > > } > > EXPORT_SYMBOL(drm_legacy_rmmap_locked); > > > > -int drm_legacy_rmmap(struct drm_device *dev, struct drm_local_map *map) > > +void drm_legacy_rmmap(struct drm_device *dev, struct drm_local_map *map) > > { > > - int ret; > > + if (!drm_core_check_feature(dev, DRIVER_KMS_LEGACY_CONTEXT) && > > + drm_core_check_feature(dev, DRIVER_MODESET)) > > + return; > > > > mutex_lock(&dev->struct_mutex); > > - ret = drm_legacy_rmmap_locked(dev, map); > > + drm_legacy_rmmap_locked(dev, map); > > mutex_unlock(&dev->struct_mutex); > > > > - return ret; > > + return; > > } > > EXPORT_SYMBOL(drm_legacy_rmmap); > > > > @@ -558,6 +560,10 @@ void drm_legacy_master_rmmaps(struct drm_device *dev, struct drm_master *master) > > { > > struct drm_map_list *r_list, *list_temp; > > > > + if (!drm_core_check_feature(dev, DRIVER_KMS_LEGACY_CONTEXT) && > > + drm_core_check_feature(dev, DRIVER_MODESET)) > > + return; > > + > > mutex_lock(&dev->struct_mutex); > > list_for_each_entry_safe(r_list, list_temp, &dev->maplist, head) { > > if (r_list->master == master) { > > diff --git a/include/drm/drm_legacy.h b/include/drm/drm_legacy.h > > index 24504b0eafea..a5ef2c7e40f8 100644 > > --- a/include/drm/drm_legacy.h > > +++ b/include/drm/drm_legacy.h > > @@ -154,7 +154,7 @@ struct drm_map_list { > > int drm_legacy_addmap(struct drm_device *d, resource_size_t offset, > > unsigned int size, enum drm_map_type type, > > enum drm_map_flags flags, struct drm_local_map **map_p); > > -int drm_legacy_rmmap(struct drm_device *d, struct drm_local_map *map); > > +void drm_legacy_rmmap(struct drm_device *d, struct drm_local_map *map); > > int drm_legacy_rmmap_locked(struct drm_device *d, struct drm_local_map *map); > > void drm_legacy_master_rmmaps(struct drm_device *dev, > > struct drm_master *master); > > -- > Jani Nikula, Intel Open Source Technology Center -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx