On Wed, Nov 11, 2015 at 11:37:06AM -0800, Rodrigo Vivi wrote: > Let's split critical PSR fixes from the series that contains other > reworks, stabilization and improvements. > > The second patch in this series isn't considered critical in terms > of functionality, but it depends on the first one and it can be consider > a fix for PSR residency on VLV/CHV. FYI I recently glanced at the psr code and a few things that left me scratching my head: - hsw_psr_enable_sink() frobs at the AUX registers without holding the hw_mutex. On SKL+ it seems to use the normal AUX registers here. Before it used the special PSR registers, so that may have been OK, but the SKL+ thing seems rather questionable. - intel_psr_enable() calls intel_psr_activate() on SKL+ but not on HSW/BDW. I'm thinking there should be a comment there to make it clear why, if it's even correct. -- Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
