On Wed, Nov 11, 2015 at 03:15:54PM +0200, Ander Conselvan de Oliveira wrote:
> The i_boost level in the DDI translation tables are stored per level.
> However, skl_ddi_set_iboos() would choose an entry of that table based
> on the port argument.
>
> Cc: Jim Bride <jim.bride@xxxxxxxxxxxxxxx>
> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@xxxxxxxxx>
> ---
Reviewed-by: Jim Bride <jim.bride@xxxxxxxxxxxxxxx>
> I noticed this while reviewing Jim's patch that updates Skylake's DDI
> translation tables. Only compile-tested.
>
> Ander
>
> drivers/gpu/drm/i915/intel_ddi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index da46edd..8cfdad2 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -2085,21 +2085,21 @@ static void skl_ddi_set_iboost(struct drm_device *dev, u32 level,
> iboost = dp_iboost;
> } else {
> ddi_translations = skl_get_buf_trans_dp(dev, &n_entries);
> - iboost = ddi_translations[port].i_boost;
> + iboost = ddi_translations[level].i_boost;
> }
> } else if (type == INTEL_OUTPUT_EDP) {
> if (dp_iboost) {
> iboost = dp_iboost;
> } else {
> ddi_translations = skl_get_buf_trans_edp(dev, &n_entries);
> - iboost = ddi_translations[port].i_boost;
> + iboost = ddi_translations[level].i_boost;
> }
> } else if (type == INTEL_OUTPUT_HDMI) {
> if (hdmi_iboost) {
> iboost = hdmi_iboost;
> } else {
> ddi_translations = skl_get_buf_trans_hdmi(dev, &n_entries);
> - iboost = ddi_translations[port].i_boost;
> + iboost = ddi_translations[level].i_boost;
> }
> } else {
> return;
> --
> 2.4.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
