Hi, On 6 November 2015 at 13:53, Daniel Stone <daniel@xxxxxxxxxxxxx> wrote: > On 5 November 2015 at 17:12, Patrik Jakobsson > <patrik.r.jakobsson@xxxxxxxxx> wrote: >> On Thu, Nov 5, 2015 at 4:02 PM, Daniel Stone <daniel@xxxxxxxxxxxxx> wrote: >>> On 3 November 2015 at 12:31, Patrik Jakobsson >>> <patrik.jakobsson@xxxxxxxxxxxxxxx> wrote: >>>> We need DC5/DC6 to be disabled around modesets to prevent confusing the >>>> DMC. Also, we've run out of bits in the 32 bit power domain mask so now >>>> it's a 64 bit mask. >>> >>> There are quite a lot of users in intel_display.c (search for >>> put_domains, display_power_put, put_power_domains) which need updating >>> for the unsigned long long change. >> >> Ah yes, we carry the mask around there as well. Thanks for catching >> that. I like the move of POWER_DOMAIN_MODESET into put_domain as well. >> I will resend the whole series again rebased on Imre's latest series. >> Ok if I incorporate your changes directly? > > Of course! Sending it like that wasn't fishing for attribution, just > that as I rebased and shifted around a bunch of other changes, > git-send-email was the most laziness-friendly option. :) Thanks for > pulling it in. If you're an admin on intel-gfx Patchwork, would you > mind marking my patch as superseded or something so it doesn't show > up? Safe to say though that I'd recommend work->put_power_domains |= (1 << POWER_MODESET), rather than |= POWER_DOMAIN_MODESET ... Cheers, Daniel _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx