Re: [PATCH 23/29] drm/i915: Wrap context LRI init in a macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 04, 2015 at 11:20:11PM +0200, ville.syrjala@xxxxxxxxxxxxxxx wrote:
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> 
> We set up a load of LRIs in the logical ring context. Wrap that stuff
> in a macro to avoid typos with position of each reg/value pair in the
> context. This also makes it easier to make the register defines type
> safe.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>

Beat me to it.

Sometimes I like being a little evil and hiding the constant parameter
passing, especially if it is localised to a single function and never
going to escape.

Fwiw,
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
and consequently for the previous patch as well.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux