On Wed, 14 Oct 2015, Animesh Manna <animesh.manna@xxxxxxxxx> wrote:
> On 9/30/2015 7:54 PM, Imre Deak wrote:
>> On ke, 2015-08-26 at 16:58 +0530, Animesh Manna wrote:
>>> Note that for bxt without dmc, display engine can go to lowest
>>> possible state (dc9), so releasing the rpm reference.
>>>
>>> Cc: Daniel Vetter <daniel.vetter@xxxxxxxxx>
>>> Cc: Damien Lespiau <damien.lespiau@xxxxxxxxx>
>>> Cc: Imre Deak <imre.deak@xxxxxxxxx>
>>> Cc: Sunil Kamath <sunil.kamath@xxxxxxxxx>
>>> Signed-off-by: Animesh Manna <animesh.manna@xxxxxxxxx>
>>> ---
>>> drivers/gpu/drm/i915/intel_csr.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
>>> index 75a775b..be388da 100644
>>> --- a/drivers/gpu/drm/i915/intel_csr.c
>>> +++ b/drivers/gpu/drm/i915/intel_csr.c
>>> @@ -392,7 +392,7 @@ static void finish_csr_load(const struct firmware *fw, void *context)
>>>
>>> DRM_DEBUG_KMS("Finished loading %s\n", dev_priv->csr.fw_path);
>>> out:
>>> - if (fw_loaded)
>>> + if (fw_loaded || IS_BROXTON(dev))
>>> intel_display_power_put(dev_priv, POWER_DOMAIN_INIT);
>> I don't think this is needed. We disable all display side runtime power
>> management if the firmware is not available. So no need to special case
>> this either imo.
> In display off case for broxton platform we can directly goto dc9 state
> for which dmc is not needed.
> So, don't want to block runtime power management from display side.
Your patch doesn't set load status to failed on bxt. There's another
version from Sagar that does [1].
BR,
Jani.
[1] http://mid.gmane.org/1444754985-15734-1-git-send-email-sagar.a.kamble@xxxxxxxxx
>
> -Animesh
>>
>>> else
>>> intel_csr_load_status_set(dev_priv, FW_FAILED);
>>
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
