On Wed, Oct 07, 2015 at 04:35:51PM +0300, Imre Deak wrote:
> On ke, 2015-10-07 at 15:29 +0200, Daniel Vetter wrote:
> > On Tue, Oct 06, 2015 at 09:16:28PM +0300, Imre Deak wrote:
> > > On pe, 2015-09-18 at 23:39 +0530, Sagar Arun Kamble wrote:
> > > > From: Akash Goel <akash.goel@xxxxxxxxx>
> > > >
> > > > Signed-off-by: Ankitprasad Sharma <ankitprasad.r.sharma@xxxxxxxxx>
> > > > Signed-off-by: Akash Goel <akash.goel@xxxxxxxxx>
> > > > Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@xxxxxxxxx>
> > >
> > > The comment about units in gen6_set_rps_thresholds() is outdated, so you
> > > could update that while at it. In any case this looks ok, so:
> > > Reviewed-by: Imre Deak <imre.deak@xxxxxxxxx>
> >
> > In your previous review you noticed that Bspec is still outdated. Has that
> > been fixed meanwhile?
>
> Yep, Sagar pointed to a page in BSpec where the relevant clocks are
> defined ("Timestamp bases") and he also filed a change request in Bspec
> now to update the register description itself accordingly. Should've
> mentioned this when adding my r-b.
Awesome. Added a note about this and applied the patch.
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
