On Tue, Oct 06, 2015 at 03:19:36PM +0100, Tvrtko Ursulin wrote: > > On 06/10/15 11:39, Chris Wilson wrote: > >Passing cliprects into the kernel for it to re-execute the batch buffer > >with different CMD_DRAWRECT died out long ago. As DRI1 support has been > >removed from the kernel, we can now simply reject any execbuf trying to > >use this "feature". > > > >To keep Daniel happy with the prospect of being able to reuse these > >fields in the next decade, continue to ensure that current userspace is > >not passing garbage in through the dead fields. > > > >v2: Fix the cliprects_ptr check > > > >Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > >Cc: Daniel Vetter <daniel.vetter@xxxxxxxx> > > Don't know anything about the DRI1 history but the removal looks > fine to me, so: > > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > > Would it also make sense to rename the related fields in > drm_i915_gem_execbuffer2 to reserved? In our heads, yes. Renaming structs in uapi.h is harder than it looks. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
