On Tue, Oct 06, 2015 at 03:29:20PM +0100, Dave Gordon wrote: > On 06/10/15 11:39, Chris Wilson wrote: > >Passing cliprects into the kernel for it to re-execute the batch buffer > >with different CMD_DRAWRECT died out long ago. As DRI1 support has been > >removed from the kernel, we can now simply reject any execbuf trying to > >use this "feature". > > > >To keep Daniel happy with the prospect of being able to reuse these > >fields in the next decade, continue to ensure that current userspace is > >not passing garbage in through the dead fields. > > > >v2: Fix the cliprects_ptr check > > > >Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > >Cc: Daniel Vetter <daniel.vetter@xxxxxxxx> > >--- > > drivers/gpu/drm/i915/i915_gem_execbuffer.c | 154 ++++++----------------------- > > drivers/gpu/drm/i915/intel_lrc.c | 15 --- > > 2 files changed, 31 insertions(+), 138 deletions(-) > > This will cause John Harrison & myself a certain amount of pain > (because the changes collide with the scheduler's reorganisation of > the execbuffer path), but I'm all in favour of getting rid of the > legacy crud cluttering up this code, so ... Oh, don't worry I'm completely rewriting it and will nak anything that adds a cycle of latency to execbuffer. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
