On Mon, Sep 28, 2015 at 03:47:55PM +0300, Ville Syrjälä wrote: > On Mon, Sep 28, 2015 at 10:59:13AM +0200, Daniel Vetter wrote: > > On Wed, Sep 23, 2015 at 06:09:04PM +0100, Chris Wilson wrote: > > > s/Export/Extract/ > > > > > > Export made me think you wanted to use it from another file. > > > > > > On Wed, Sep 23, 2015 at 12:52:24PM -0300, Paulo Zanoni wrote: > > > > Make the giant function a little less giant > > > > > > ...and make it a little more self-documenting by refactoring the > > > valid size predicate.. > > > > > > > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> > > > > --- > > > > drivers/gpu/drm/i915/intel_fbc.c | 35 ++++++++++++++++++++++------------- > > > > 1 file changed, 22 insertions(+), 13 deletions(-) > > > > > > > > diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c > > > > index 0a6b454..0c7b59b 100644 > > > > --- a/drivers/gpu/drm/i915/intel_fbc.c > > > > +++ b/drivers/gpu/drm/i915/intel_fbc.c > > > > @@ -755,6 +755,26 @@ static bool pixel_format_is_valid(struct drm_framebuffer *fb) > > > > } > > > > } > > > > > > > > +static bool size_is_valid(struct intel_crtc *crtc) > > > > > > Which size? > > > > > > pipe_size_fits_in_fbc() > > > pipe_size_valid() > > > pipe_size_fits() > > > > > > I think I prefer pipe_size_valid(). > > > > Painted while applying, thanks. > > And it's not what we really want. We should be looking at the plane src size. Well it also lookst at intel_crtc->config and not crtc->state so not perfect from that pov either. And since it's really just a 1:1 refactor I figured I can pull this before we figure out the exact details - we should be able to get at everything interesting through the intel_crtc. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
