On Jul 28 2015 or thereabouts, Chris Wilson wrote: > On Tue, Jul 28, 2015 at 12:03:28PM -0400, Benjamin Tissoires wrote: > > We check the polarity of the attached dp, so it is normal to fail. > > Do not send errors to the users. > > if (probe) DRM_DEBUG else DRM_ERROR is fairly offensive. > > It strikes me that you could make each of these functions report the > failure to the caller (have the caller even do so error handling!) and > as part of that have the caller report an error and so demote all of > these to DRM_DEBUG_KMS(). Yes, sorry for that. I will change it to return an actual error code and the error string if I still need to use these functions given Sivakumar ideas. > > Who knows, actually doing some error handling may make monitor training > more reliable! Or we may even get carried away and report the failure > all the way back to userspace. That would be a very good improvement indeed. But I can already tell you that I will not do it by myself, I already have too much on my plate. I'll do my share for this feature, but don't count on me for the whole error handling rewrite :) Cheers, Benjamin _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
