On Tue, Jul 28, 2015 at 12:03:28PM -0400, Benjamin Tissoires wrote: > We check the polarity of the attached dp, so it is normal to fail. > Do not send errors to the users. if (probe) DRM_DEBUG else DRM_ERROR is fairly offensive. It strikes me that you could make each of these functions report the failure to the caller (have the caller even do so error handling!) and as part of that have the caller report an error and so demote all of these to DRM_DEBUG_KMS(). Who knows, actually doing some error handling may make monitor training more reliable! Or we may even get carried away and report the failure all the way back to userspace. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
