On Thu, Jul 23, 2015 at 10:15:03AM +0100, Lee Jones wrote: > On Thu, 23 Jul 2015, Daniel Vetter wrote: > > > On Thu, Jul 23, 2015 at 9:38 AM, Lee Jones <lee.jones@xxxxxxxxxx> wrote: > > > On Wed, 22 Jul 2015, Daniel Vetter wrote: > > >> On Wed, Jul 22, 2015 at 02:01:44PM +0530, Shobhit Kumar wrote: > > >> > This is needed as the CRC PMIC has support for Panel > > >> > enable/diable as gpio which needs 'gpiod_add_lookup_table' > > >> > and 'gpiod_remove_lookup_table' from gpiolib. This patch > > >> > can be squashed with below commit in topic/crc-pmic branch > > >> > > > >> > commit 61dd2ca2d44e493b050adbbb75bc50db11c367dd > > >> > Author: Shobhit Kumar <shobhit.kumar@xxxxxxxxx> > > >> > Date: Fri Jun 26 14:32:05 2015 +0530 > > >> > > > >> > mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO > > >> > signal > > >> > > > >> > On some Intel SoC platforms, the panel enable/disable signals > > >> > are controlled by CRC PMIC. Add those control as a new GPIO in a > > >> > lookup table for gpio-crystalcove chip during CRC driver load > > >> > > > >> > Cc: Lee Jones <lee.jones@xxxxxxxxxx> > > >> > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> > > >> > Signed-off-by: Shobhit Kumar <shobhit.kumar@xxxxxxxxx> > > >> > > >> Applied, thanks. > > > > > > You can't just apply changes made to other subsystems willy-nilly. > > > > > > You should wait for an Ack, despite the triviality of the patch, even > > > if it's just out of courtesy. > > > > Sorry about that, figured getting rid of the compile fail asap is > > better. Should I revert it again and update the pull request? > > It's fine. Just please bear it in mind for the future. Sure will wait for ack the next time around. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
