Re: [PATCH 4/5] drm/i915: Remove wait_for_pending_flips from disable_noatomic.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Op 21-07-15 om 13:35 schreef Chris Wilson:
> On Thu, Jul 16, 2015 at 02:57:50PM +0200, Maarten Lankhorst wrote:
>> Now that intel_display_suspend is atomic it's safe to remove
>> wait_for_pending_flips from intel_crtc_disable_noatomic. It
>> will only be used during hw load or resume, in which case there
>> will be no pending flips anyway.
> A WARN_ON(pending_flip) then? (Actually we should start doing
> DRM_ERROR_ON I guess that would make a lot of complaints go away, and
> also a lot of genuine bug reports) Or do we have warning coverage
> elsewhere along the CRTC change path?

intel_sanitize_crtc, called during hw readout, is the only caller of intel_crtc_disable_noatomic.
During hw readout no sw updates should be queued anyway..

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux