On Tue, Jul 07, 2015 at 03:38:37AM +0800, Zhi Wang wrote: > Hi Chris: > Thanks for the comments! I can understand that we're concerned > about regressions, so this is why I think put this reset in module > unload path looks much safer. For safety, maybe we should only reset > GPU perhaps only when GEN >= 6? That looks much easier and safer, > also combine execlist reset and power context reset. > > Or we just add this before i915_uncore_fini() inside > i915_driver_unload()? This way looks much safer? > > How about this one? No, if we are just targetting execlists, then disabling it in cleanup_ringbuffers as before is the cleanest (as that is the opposite stage to where we enable them). The reset in i915_driver_unload() is preferred to replace all the resets required during unload. It is safe to move the context reset here as we do not disturb the GTT state between unpining the context and here. Making it conditional on gen>=5 is probably a good first step. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
