Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> writes: > On Sat, Jul 04, 2015 at 12:27:34AM +0800, bing.niu@xxxxxxxxx wrote: >> From: "Niu,Bing" <bing.niu@xxxxxxxxx> >> >> It is found that i915 will not reset gpu under execlist mode when >> unload module. that will lead to some issues when unload/load module >> with different submission mode. e.g. from execlist mode to ring >> buffer mode via loading/unloading i915. Because HW is not in a reset >> state and registers are not clean under such condition. >> >> Signed-off-by: Niu,Bing <bing.niu@xxxxxxxxx> > Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > I think we may end up doing the reset unconditionally in > i915_driver_unload() because this argument holds for almost everything > we setup. It's a bigger risk because of doing the gpu-reset on more > machines, but module-unloading is a "developer feature"! And after that has been sorted, we should try reset on module load. This way initial state would be identical to after reset/unload state. Now we have this situation that we don't know how much we are leaning on bios on state setup. -Mika > The only issue is making sure that the reset is ordered appropriately. > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
