2015-07-01 9:19 GMT-03:00 Daniel Vetter <daniel@xxxxxxxx>: > On Thu, Jun 25, 2015 at 03:16:37PM +0200, Daniel Vetter wrote: >> On Thu, Jun 25, 2015 at 02:18:06PM +0300, David Weinehall wrote: >> > On Thu, Jun 25, 2015 at 09:37:22AM +0200, Daniel Vetter wrote: >> > > On Thu, Jun 25, 2015 at 09:14:09AM +0300, David Weinehall wrote: >> > > > Looks good. >> > > > >> > > > Reviewed-by: David Weinehall <david.weinehall@xxxxxxxxxxxxxxx> >> > > > >> > > > On Thu, Jun 18, 2015 at 02:23:37PM +0300, Antti Koskipaa wrote: >> > > > > An OEM may request increased I_boost beyond the recommended values >> > > > > by specifying an I_boost value to be applied to all swing entries for >> > > > > a port. These override values are specified in VBT. >> > > > > >> > > > > Issue: VIZ-5676 >> > > > > Signed-off-by: Antti Koskipaa <antti.koskipaa@xxxxxxxxxxxxxxx> >> > > >> > > What depencies has this patch? Please either mention that or include this >> > > patch in whatever other patch series it needs, since I can't apply this. >> > > Maybe it also simply needs a rebase, but conflicts don't look like that. >> > >> > As mentioned in Antti's reply to the patch, it depends on >> > "drm/i915/skl: Buffer translation improvements". >> > >> > Antti's patch still applies against v2 of my patch, but with some slight >> > fuzz. >> >> Light fuzz I can handle. In the future can you pls just include Antti's >> patch when submitting yours in the same series? That way I won't miss it. > > Queued for -next, thanks for the patch. Git bisect tells me this commit introduced the following message when I boot BDW: [drm:intel_parse_bios [i915]] *ERROR* General definiton block child device size is too small. These are the lines around it: [ 8.607616] [drm] Driver supports precise vblank timestamp query. [ 8.607623] [drm:init_vbt_defaults] Set default to SSC at 120000 kHz [ 8.607630] [drm:validate_vbt] Using VBT from OpRegion: $VBT HASWELL d [ 8.607638] [drm:parse_general_features] BDB_GENERAL_FEATURES int_tv_support 0 int_crt_support 0 lvds_use_ssc 0 lvds_ssc_freq 120000 display_clock_mode 0 fdi_rx_polarity_inverted 0 [ 8.607651] [drm:parse_general_definitions] crt_ddc_bus_pin: 2 [ 8.607658] [drm:parse_lfp_panel_data] DRRS supported mode is static [ 8.607674] [drm:parse_lfp_panel_data] Found panel mode in BIOS VBT tables: [ 8.607682] [drm:drm_mode_debug_printmodeline] Modeline 0:"1920x1080" 0 138780 1920 1966 1996 2080 1080 1082 1086 1112 0x8 0xa [ 8.607692] [drm:parse_lfp_panel_data] VBT initial LVDS value 30033c [ 8.607699] [drm:parse_lfp_backlight] VBT backlight PWM modulation frequency 200 Hz, active high, min brightness 0, level 255 [ 8.607719] [drm:parse_sdvo_panel_data] Found SDVO panel mode in BIOS VBT tables: [ 8.607728] [drm:drm_mode_debug_printmodeline] Modeline 0:"1600x1200" 0 162000 1600 1664 1856 2160 1200 1201 1204 1250 0x8 0xa [ 8.607738] [drm:parse_sdvo_device_mapping] different child size is found. Invalid. [ 8.607773] [drm:intel_parse_bios [i915]] *ERROR* General definiton block child device size is too small. [ 8.607782] [drm:parse_driver_features] DRRS State Enabled:1 [ 8.609574] [drm:intel_dsm_pci_probe] no _DSM method for intel device [ 8.609604] [drm:i915_gem_init_stolen] found 33554432 bytes of stolen memory at ae000000 > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Paulo Zanoni _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx