On Wed, 10 Jun 2015, "O'Rourke, Tom" <Tom.O'Rourke@xxxxxxxxx> wrote: >> > + >> > + dev_priv->rps.efficient_freq *= >> > + (IS_SKYLAKE(dev) ? GEN9_FREQ_SCALER : 1); > > This line seems awkward. I suppose a good compiler could > optimize out the multiply by one. > > I would prefer something like: > > if(IS_SKYLAKE(dev)) > dev_priv->rps.efficient_freq *= GEN9_FREQ_SCALER; Agreed, Jani. > > -- Tom O'Rourke > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
