On Tue, May 26, 2015 at 04:47:45PM +0000, Morton, Derek J wrote: > -----Original Message----- > From: daniel.vetter@xxxxxxxx [mailto:daniel.vetter@xxxxxxxx] On Behalf Of Daniel Vetter > Sent: Tuesday, May 26, 2015 4:27 PM > To: Morton, Derek J > Cc: intel-gfx; Wood, Thomas > Subject: Re: [PATCH i-g-t] lib/tests/igt_segfault.c Add unit test to test segfault handling > > >On Tue, May 26, 2015 at 5:05 PM, Derek Morton <derek.j.morton@xxxxxxxxx> wrote: > >> + * The test consists of three subtests. The first and third should > >> + pass > >> + * while the second should cause a segfault. > >> + * The overall result should be a failure with two subtests passing. > > >You need to split this up into separate binaries and mark the expected failure with XFAIL_TESTS. Or write a short wrapper for it that checks that we get the right kind of failure ... > > The aim of the test was to ensure the overall test returns an failure > code if a subtest segfaults. I put a passing subtest before and after > the one that crashes to test that the crashing subtest does not affect > the other subtests. I guess I could write a script to check the > individual subtest results. Adding a scrip to parse subtest results means when we ever change the convention (or just the output printed, which isn't part of the stable testrunner interface) then this testcase fails. Imo just copypaste the testcase and specialize all the different variants you want to test. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
