On Tue, May 12, 2015 at 05:18:47PM +0100, Damien Lespiau wrote: > On Tue, May 12, 2015 at 06:13:25PM +0200, Daniel Vetter wrote: > > On Tue, May 12, 2015 at 04:13:19PM +0100, Damien Lespiau wrote: > > > While we have been historically exposing those formats, but the hardware > > > doesn't do anything with the alpha bits. The DDX doesn't seem to > > > particularly care about those formats either, so just expose the > > > XRGB/XBGR variants. > > > > > > Signed-off-by: Damien Lespiau <damien.lespiau@xxxxxxxxx> > > > > We have this problem with all the primary planes. Imo we should remove > > this everywhere, since the ddx doesn't seem to care. > > Well technically that'd be breaking ABI (very unlikely, but still). So > I'd rather have this SKL-specific patch (because we haven't committed to > SKL just yet) separate from the patch removing the formats for previous > platforms in case we need to revert. I'll cook the patch for previous > platform as a follow up. It's only breaking ABI if someone notices, which is wiggle room we exploit a _lot_ to fix up past mistakes. I'm ok with merging the skl and pre-skl parts as two patches in case of reverting, but I really think we should do them all in one go. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
