On Mon, Mar 02, 2015 at 04:49:31PM +0200, Ville Syrjälä wrote: > On Mon, Mar 02, 2015 at 03:44:58PM +0100, Daniel Vetter wrote: > > On Fri, Feb 27, 2015 at 08:09:20PM +0200, Ville Syrjälä wrote: > > > Actually this is going to have issues now that atomic is partially in. > > > We'd need to look at plane->state->fb now, but that steps on the same > > > turf as Matt's latest patches. > > > > All the wm computation needs to be moved over to look at plane states, not > > plane->state - we need to do all this in the check phase when state > > objects haven't been commited yet. Which is a lot more work and probably > > best done separately in one go than all over the place and inconsistently. > > Sure, but the quick "keep things sort of working" fix is to look at > plane->state since we currently do the wm calculation from commit. Yeah my reply was just with your comment about stepping onto Matt's turf. The minimal change to look at plane->state->fb is obviously needed and we can't avoid such conflicts really. Just figured we shouldn't charge ahead with changing interfaces all over the place. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
