Thanks for the explanation. As soon as I get my GT3 back I do another round, but with your explanations and with the code I've re-reviewed I'm confident everything is right. Thanks, Rodrigo. On Tue, Jan 20, 2015 at 5:10 PM, Gong, Zhipeng <zhipeng.gong@xxxxxxxxx> wrote: > > >> -----Original Message----- >> From: Rodrigo Vivi [mailto:rodrigo.vivi@xxxxxxxxx] >> Sent: Wednesday, January 21, 2015 5:49 AM >> To: Gong, Zhipeng >> Cc: intel-gfx; Vivi, Rodrigo >> Subject: Re: [PATCH 3/3] test/gem_dummy_reloc_loop: add tests for >> dual bsd ring >> >> On Mon, Jan 12, 2015 at 4:50 PM, Zhipeng Gong <zhipeng.gong@xxxxxxxxx> >> wrote: >> > Signed-off-by: Zhipeng Gong <zhipeng.gong@xxxxxxxxx> >> > --- >> > tests/gem_dummy_reloc_loop.c | 18 ++++++++++++++++++ >> > 1 file changed, 18 insertions(+) >> > >> > diff --git a/tests/gem_dummy_reloc_loop.c >> > b/tests/gem_dummy_reloc_loop.c index 335700d..5e0a10a 100644 >> > --- a/tests/gem_dummy_reloc_loop.c >> > +++ b/tests/gem_dummy_reloc_loop.c >> > @@ -43,6 +43,8 @@ >> > #include "intel_chipset.h" >> > >> > #define LOCAL_I915_EXEC_VEBOX (4<<0) >> > +#define LOCAL_I915_EXEC_BSD_RING1 (1<<13) #define >> > +LOCAL_I915_EXEC_BSD_RING2 (2<<13) >> > >> > static drm_intel_bufmgr *bufmgr; >> > struct intel_batchbuffer *batch; >> > @@ -260,6 +262,22 @@ igt_main >> > } >> > #endif >> > >> > + igt_subtest("bsd-ring1") { >> > + igt_require(gem_has_bsd2(fd)); >> Should we really skip this if bsd2 isn't present? >> On my GT2: >> Test requirement not met in function __real_main179, file >> gem_dummy_reloc_loop.c:266: >> Test requirement: gem_has_bsd2(fd) >> Subtest bsd-ring1: SKIP (0.000s) >> > Yes, I915_EXEC_BSD_RING1 only take effects on the platform with 2VDBOX. > In kernel, the code is like this, it has a precondition of HAS_BSD2(dev). > if (HAS_BSD2(dev)) { > int ring_id; > switch (args->flags & I915_EXEC_BSD_MASK) { > ... > case I915_EXEC_BSD_RING1: > ring = &dev_priv->ring[VCS]; > break; > ... > > >> > + sleep(2); >> > + igt_info("running dummy loop on bsd-ring1\n"); >> > + >> dummy_reloc_loop(I915_EXEC_BSD|LOCAL_I915_EXEC_BSD_RING1); >> > + igt_info("dummy loop run on bsd-ring1 completed\n"); >> > + } >> > + >> > + igt_subtest("bsd-ring2") { >> > + igt_require(gem_has_bsd2(fd)); >> > + sleep(2); >> > + igt_info("running dummy loop on bsd-ring2\n"); >> > + >> dummy_reloc_loop(I915_EXEC_BSD|LOCAL_I915_EXEC_BSD_RING2); >> > + igt_info("dummy loop run on bsd-ring2 completed\n"); >> > + } >> > + >> > igt_subtest("mixed") { >> > if (num_rings > 1) { >> > sleep(2); >> > -- >> > 1.8.3.1 >> > >> > _______________________________________________ >> > Intel-gfx mailing list >> > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx >> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx >> >> >> >> -- >> Rodrigo Vivi >> Blog: http://blog.vivi.eng.br -- Rodrigo Vivi Blog: http://blog.vivi.eng.br _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
