On Wed, Nov 12, 2014 at 09:44:34AM +0100, Daniel Vetter wrote:
> On Fri, Nov 07, 2014 at 02:22:01PM -0800, bradley.d.volkin@xxxxxxxxx wrote:
> > + if (obj && obj->madv == __I915_MADV_PURGED) {
> > + was_purged = true;
> > + list_del(&obj->batch_pool_list);
> > + drm_gem_object_unreference(&obj->base);
> > + obj = NULL;
> > + }
>
> Minor issue: We should move the purged check into the loop so that purge
> buffer structs get released even when they're too small/big. Otherwise
> we'll have a good chance to hang onto gobloads of structs forever.
I mentioned that we should do the purge of structs in our oom-notifier
as well to be safe.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
