On Mon, Nov 10, 2014 at 04:13:02PM +0200, Imre Deak wrote: > On Mon, 2014-11-10 at 13:45 +0000, Chris Wilson wrote: > > On Mon, Nov 10, 2014 at 03:41:05PM +0200, Imre Deak wrote: > > > Atm we first enable the RPS interrupts then we clear any pending ones. > > > By this we could lose an interrupt arriving after we unmasked it. This > > > may not be a problem as the caller should handle such a race, but logic > > > still calls for the opposite order. Also we can delay enabling the > > > interrupts until after all the RPS initialization is ready with the > > > following order: > > > > > > > 0. disable left-over RPS > > Isn't enough relying on > intel_uncore_sanitize()->intel_disable_gt_powersave()? That should be enough. It's an important step to remember though :) > > > 1. clear any pending RPS interrupts > > > 2. initialize RPS > > > 3. enable RPS interrupts -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
