On Wed, Nov 05, 2014 at 11:25:51AM +0100, Daniel Vetter wrote: > On Tue, Nov 04, 2014 at 05:06:38PM +0000, Damien Lespiau wrote: > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > > index 7a69eba..761c884 100644 > > --- a/drivers/gpu/drm/i915/intel_pm.c > > +++ b/drivers/gpu/drm/i915/intel_pm.c > > @@ -2271,11 +2271,56 @@ hsw_compute_linetime_wm(struct drm_device *dev, struct drm_crtc *crtc) > > PIPE_WM_LINETIME_TIME(linetime); > > } > > > > -static void intel_read_wm_latency(struct drm_device *dev, uint16_t wm[5]) > > +static void intel_read_wm_latency(struct drm_device *dev, uint16_t wm[8]) > > Imo we should split this into an ilk_read_wm_latency and a > skl_read_wm_latency function. It's big and all the callers seem to only > care about one or the other. Care for a follow-up patch? Actually there seem to be a few more functions which are platform specific. E.g. the intel_fixup* functions - tbh we might as well just inline them. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
