On Tue, Nov 4, 2014 at 1:21 PM, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote: >> > drm/i915: Refactor vlv_display_irq_uninstall() >> >> Except this, I think consens is that we don't need it? > > No, it's needed by the later patches. Trying to replace the vlv/chv > uninstall() hooks with reset() is best left for another series IMO. > And doing that involves more than just reviewing the the display irq > install/uninstall paths. Eg. currently VLV_MASTER_IER handling is > very inconsistent. Well I think we should just open-code it for chv and not do this extraction. All the complexity here is due to vlv runtime pm, and somehow I still think that this should work more magically. At least it should be possible if we start to handle power domains in the system s/r code instead of just force-enabling them all. So my idea was to drop this one and rebase the remaining few patches on top. That way we have a nice reminder that there's still work to do. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
