> -----Original Message----- > From: daniel.vetter@xxxxxxxx [mailto:daniel.vetter@xxxxxxxx] On Behalf Of > Daniel Vetter > Sent: Thursday, September 18, 2014 7:57 PM > To: Gore, Tim > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; Gardiner, Kelvin; Joncour, Yann; Sharp, > Robert; Daniel, Thomas > Subject: Re: turn off lowmemorykiller when running IGT on Android? > > On Thu, Sep 18, 2014 at 5:42 PM, Gore, Tim <tim.gore@xxxxxxxxx> wrote: > > Hi All. > > After some pain trying to resolve an IGT test getting killed by the > > Android Lowmemorykiller, it seems to me that in the context of the > > IGT tests we just don't need (or want) the android low memory killer. > > The Linux memory management and oom functions are perfectly > adequate. > > Rob Becket kindly pointed me to a module parameter I can adjust to > > effectively stop the low memory killer from killing anything and I > > would like to suggest that we use this with all IGT tests when run on > Android. > > > > echo "9999" > /sys/module/lowmemorykiller/parameters/adj > > > > This is easily done from the console but I think we should put it in > > igt_core.c So that it does not get forgotten, perhaps by adding it to > > the omm_adjust_for_doom function (within #ifdef ANDROID of course). > > What do people think? > > Adding this to igt_core with a cleanup handler sounds like a plan. And really, > the android lowmemkiller is just broken for aiming at processes owned by > root, but apparently we can't fix that. > > But please add this _without_ and #ifdef ANDROID since there are linux > distros out there (*cough* ubuntu *cough*) which for incomprehensible > reasons add everything under CONFIG_ANDROID ... > -Daniel > -- Thanks Daniel, as you say it needs to be cleaned up afterwards. I can avoid the #ifdef ANDROID, but I didn't understand the issue; what do you mean when you Say "add everything under CONFIG_ANDROID"? There are already a couple of Places where we use #ifdef ANDROID in the IGT code (drmtest.h and ralloc.c). Do these also represent a problem. Tim > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
