On Tue, Sep 09, 2014 at 11:53:15AM +0530, shashank.sharma@xxxxxxxxx wrote: > From: Shashank Sharma <shashank.sharma@xxxxxxxxx> > > This patch adds support for CSC correction color property. > It does the following: > 1. Creates a new DRM property for CSC correction. Adds this into > mode_config. ... One thing I forgot to ask in my response yesterday...does it make sense to create this property in dev->mode_config rather than in dev_priv? Some properties (like the plane rotation property that went in a little while ago) do seem like a good match for dev->mode_config because they're generic concepts that a lot of different drivers will want to reuse (and in some cases the common core/helper library code might want to make use of them as well, as we do in restore_fbdev_mode()). But it's unclear to me whether non-Intel hardware handles color correction similarly enough that the CSC property you're creating here is something other drivers will ever use, or whether it will always be an Intel-specific thing. My understanding is that the values here are very Intel-specific, so there's never going to be an opportunity for core/helper library code to make use of the property, right? If this does turn out to be an Intel-only property, then it's probably better to move it to dev_priv (where we have a couple of our connector properties today). If you do decide that there's potential for reuse by other drivers and that you want to keep this in dev->mode_config you'll want to make sure you Cc the dri-devel mailing list on the patches that touch the DRM core files. Matt -- Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
